[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] master - cleanup: lvm complient style



Dne 25.7.2013 00:36, Tony Asleson napsal(a):
On 07/22/2013 05:42 AM, Zdenek Kabelac wrote:
Gitweb:        http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=d4ad728610db1751af1eab2c8c7d6130a3742394
Commit:        d4ad728610db1751af1eab2c8c7d6130a3742394
Parent:        05a70f2da306164f3c604c50d69e74090b0028bc
Author:        Zdenek Kabelac <zkabelac redhat com>
AuthorDate:    Fri Jul 19 15:33:26 2013 +0200
Committer:     Zdenek Kabelac <zkabelac redhat com>
CommitterDate: Mon Jul 22 12:41:21 2013 +0200

cleanup: lvm complient style

drop unused assignments.

...

  		/* Each call to PyModule_AddObject decrefs it; compensate: */
-		Py_INCREF(LibLVMError);
-		Py_INCREF(LibLVMError);
-		PyModule_AddObject(m, "error", LibLVMError);
-		PyModule_AddObject(m, "LibLVMError", LibLVMError);
+		Py_INCREF(_LibLVMError);
+		Py_INCREF(_LibLVMError);
+		PyModule_AddObject(m, "error", _LibLVMError);
+		PyModule_AddObject(m, "_LibLVMError", _LibLVMError);

This changed the visible exception from LibLVMError to _LibLVMError
which breaks existing python code.


Ahhh my bad - find&replace - and I've missed  "" around.
I'll commit fix.

Zdenek




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]