[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH] lvm2app: Add thin and thin pool lv creation V2



On 05/06/2013 10:47 AM, Zdenek Kabelac wrote:
> We already have the API 'explosion' for  lvs/pvs/vgs properties.
> So I think it could probably share the same principal for lvcreate attrs.

For API consistency we probably should use the same technique for
get/set proprieties like we do in other parts of the API, for some
reason when you mentioned more C++ like I went with a separate get/set
functions.  I've mentioned before that I don't like returning structures
by value because there is a potential link issues if the library and
client code compiled with different options:
-fpcc-struct-return/-freg-struct-return.

> I liked the 'X protocol' way of using string named fields - but then
> you lose compile time check whether you pass valid arguments...

We are going to lose compile time enforcement regardless if we want
generic get/set functionality.

Regards,
Tony


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]