[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH 05/19] lvm2app: Move core lv re-size code (v2)

Dne 9.5.2013 00:45, Tony Asleson napsal(a):
Moved to allow use from command line and for library use.

Signed-off-by: Tony Asleson <tasleson redhat com>
  lib/metadata/lv_manip.c          | 734 +++++++++++++++++++++++++++++++++++++
  lib/metadata/metadata-exported.h |  46 +++
  tools/lvresize.c                 | 773 +--------------------------------------
  3 files changed, 781 insertions(+), 772 deletions(-)

diff --git a/lib/metadata/lv_manip.c b/lib/metadata/lv_manip.c
index 42e0fab..587cbd2 100644
--- a/lib/metadata/lv_manip.c
+++ b/lib/metadata/lv_manip.c
@@ -27,6 +27,8 @@
  #include "activate.h"
  #include "str_list.h"
  #include "defaults.h"
+#include "lvm-exec.h"
+#include "errors.h"

This '/tools' error from   '/lib'  needs some solution.

Currently /lib reports  1 success, 0 error - and potential error state is
returned via some other mechanism (i.e. setting struct member...)

On the other hand the lvm2app is seriously missing error reporting - since
the user of this API is usually not seeing typical lvm2 log_error messages.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]