[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH] Better clean-up of pvmove failures in a cluster



Dne 5.5.2014 23:38, Jonathan Brassow napsal(a):
Hi,

I don't see any reason why the following patch would be bad, but I'd
like to hear from others first.  In essence, I'm just trying to improve
the error code path.  This seems to improve things for pvmove when a
node in the cluster is not running 'cmirrord' as it should.  However, it
doesn't clean everything up when attempting to create a full cluster
mirror LV.  So there might still be some work left after this.

I've already tried to add some initial recovery support for error path.

If you take a look into the upstream libdm-deptee code - there is already
dnode->activated  list for recovery path - which track just newly introduced
devices.

The problem is however much more complicated - it should work as transaction,
since multiple device may get changed - and all changes should be
reverted properly.


  brassow

activation:  Remove empty DM devices when table fails to load.

There is postprocessing routine which should cleanup any left
empty entries in the table.

I'm currently working on more generic solution.

Zdenek


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]