[PATCH] Fix for Flash 10 windowless mode

[gb.public at free.fr]

Hi,

----- "Martin Stransky" <stransky at redhat.com> a écrit :

> we use a minimal version of this patch in fedora now (just the check
> in 
> npw-rpc.c) and I forget to propagate it back. Anyway, the 
> gdk_visual_get_system() looks like a nice trick, I'll update our
> packages.

I noticed it in your packages too (hence the ChangeLog) but, in my opinion, that version could lead to problems because ws_info->display would not have been set. You should even have got an error in the viewer.

BTW, nspluginwrapper, prior to supporting windowless plugins, always set ws_info->visual too. So, in some way, it's a regression from the previous version. We probably should also set something for ws_info->colormap. I don't know why firefox had ws_info->visual == NULL though, I will check the sources later. IIRC, NPAPI specs mention those for windowless plugins too, so it's my assumption they should be filled in with valid values, though they were not saying that explicitly either.

I used a nightly build of firefox trunk (3.1-something) from yesterday. A testcase was <http://www.tf1.fr/> (full of Flash!). If you still see problems with that patch, please tell me which site. Thanks.

Regards,
Gwenole.