[PATCH] Fix for Flash 10 windowless mode

[Warren Togami]

gb.public at free.fr wrote:
> 
> I noticed it in your packages too (hence the ChangeLog) but, in my
> opinion, that version could lead to problems because ws_info->display
> would not have been set. You should even have got an error in the
> viewer.
> 
> BTW, nspluginwrapper, prior to supporting windowless plugins, always
> set ws_info->visual too. So, in some way, it's a regression from the
> previous version. We probably should also set something for
> ws_info->colormap. I don't know why firefox had ws_info->visual ==
> NULL though, I will check the sources later. IIRC, NPAPI specs
> mention those for windowless plugins too, so it's my assumption they
> should be filled in with valid values, though they were not saying
> that explicitly either.
> 
> I used a nightly build of firefox trunk (3.1-something) from
> yesterday. A testcase was <http://www.tf1.fr/> (full of Flash!). If
> you still see problems with that patch, please tell me which site.
> Thanks.
> 
> Regards, Gwenole.

Here are two confirmed problems...

[root at newcaprica /]# rpm -q firefox nspluginwrapper flash-plugin
firefox-3.0.2-1.fc9.x86_64
nspluginwrapper-1.1.0-7.fc9.i386
nspluginwrapper-1.1.0-7.fc9.x86_64
flash-plugin-10.0.0.569-release.i386

http://kojipkgs.fedoraproject.org/packages/nspluginwrapper/1.1.0/7.fc9/
This build uses your new patch.

http://news.google.com/
The embedded Youtube videos here begin playing if you click on the "+ 
Video" links.  It seems to expand using javascript to reveal a Youtube 
video.  If you did not disable windowless mode, then it displays with 
visual glitches and soon dies.  It seems to work unwrapped.

http://www.theonion.com/content/video/economists_warn_anti_bush
This video seems to crash readily if a Flash ad happens in rotation 
while the video is playing.

Warren