[Open-scap] Patch for TODOs

[Peter Vrabec]

at first glance it seems there is extra

free(variableId);

in  oval_variable_binding_parse_tag();


On Thursday 30 July 2009 04:36:13 pm Peter Vrabec wrote:
> Hi David,
>
> thnx. for update. But unfortunately it breaks populating of system
> characteristic. :)
>
> $make check
> ....
> + ./test_syschar ./OVAL/composed-oval.xml ./OVAL/system-characteristics.xml
> START
> LOAD OVAL DEFINITIONS
> OVAL DEFINITIONS LOADED
> LOAD OVAL SYSCHAR
> *** glibc detected ***
> /home/pvrabec/openscap/examples/.libs/lt-test_syschar: double free or
> corruption (fasttop): 0x0000000002504200 ***
> ======= Backtrace: =========
> /lib64/libc.so.6[0x3efd875a26]
> /home/pvrabec/openscap/src/.libs/libopenscap.so.0(oval_variable_binding_par
>se_tag+0x6c) [0x7f4bd9ab31ac]
> /home/pvrabec/openscap/src/.libs/libopenscap.so.0(_oval_syschar_parse_subta
>g+0x135) [0x7f4bd9ab1c65]
> /home/pvrabec/openscap/src/.libs/libopenscap.so.0(oval_parser_parse_tag+0xa
>4) [0x7f4bd9aae524]
> /home/pvrabec/openscap/src/.libs/libopenscap.so.0(oval_syschar_parse_tag+0x
>236) [0x7f4bd9ab1a36]
> /home/pvrabec/openscap/src/.libs/libopenscap.so.0(oval_parser_parse_tag+0xa
>4) [0x7f4bd9aae524]
> /home/pvrabec/openscap/src/.libs/libopenscap.so.0(_ovalsys_parser_process_n
>ode+0x264) [0x7f4bd9ab35c4]
> /home/pvrabec/openscap/src/.libs/libopenscap.so.0(ovalsys_parser_parse+0x15
>b) [0x7f4bd9ab373b]
> ...
>
> On Thursday 30 July 2009 03:39:29 pm David Niemoller wrote:
> > Please find attached some source updates that address several of TODOs
> > in the current code base.
>
> _______________________________________________
> Open-scap-list mailing list
> Open-scap-list at redhat.com
> https://www.redhat.com/mailman/listinfo/open-scap-list