[Open-scap] open-scap rpm 5

[Martin Preisler]

Hi,

----- Original Message -----
> From: "Андрей Рудаков" <melhior at altx-soft.ru>
> To: slukasik at redhat.com
> Cc: open-scap-list at redhat.com
> Sent: Friday, December 13, 2013 1:06:55 PM
> Subject: Re: [Open-scap] open-scap rpm 5
> 
> Hello Simon,
> 
> 
> dl.patch:
> 
> fixes "undefined reference to `dlopen', `dlclose' ... " issue at some
> platforms

Please see documentation of libdl, excerpt:
Historically,  functions in libdl provided for dynamic linking support.
This functionality now resides in libc(3LIB).

I don't think it's a good idea to merge this without any sort of detection
whether this legacy is needed on the platform or not.

> 
> 
> literal.patch:
> 
> fixes "Security: Format string is not a string literal" issue in shadow.c
> probe.

Good catch, this was applied, see commit 33fb73fdbb9068ed03ff335c4a5f8322280db197.

> 
> rpm5.patch:
> 
> just replaces rpm4 implementation with rpm5
> 

We can't just replace rpm4 support with rpm5. That would mean dropping rpm4
support. Keep in mind that rpm4 and rpm5 are diverging codebases. I am in favor
of supporting rpm5 but it has to be an optional and must coexist alongside rpm4
support. Can't merge this in its current state.

-- 
Martin Preisler