[Open-scap] fix process58 for Ubuntu

Bruno Ducrot bruno at poupinou.org
Tue Sep 5 14:05:50 UTC 2017


Hi there,

Compiling OpenSCAP 1.2.15 under a Ubuntu Xenial.  The probe for
process58 will segfault.  A possible fix for that could be :

diff -Nur openscap-1.2.15/src/OVAL/probes/unix/process58.c openscap-fix-process58-1.2.15/src/OVAL/probes/unix/process58.c
--- openscap-1.2.15.orig/src/OVAL/probes/unix/process58.c	2017-08-25 14:24:01.000000000 +0200
+++ openscap-1.2.15/src/OVAL/probes/unix/process58.c	2017-09-05 15:55:04.442257234 +0200
@@ -247,10 +247,11 @@
 		dW("Can't get selinux context for process %d", pid);
 		return NULL;
 	}
-	context = context_new(pid_context);
-	selinux_label = strdup(context_type_get(context));
-	context_free(context);
-	freecon(pid_context);
+	// context = context_new(pid_context);
+	// selinux_label = strdup(context_type_get(context));
+	// context_free(context);
+	// freecon(pid_context);
+	selinux_label = strdup(pid_context);
 	return selinux_label;
 
 #else


I guess that fix is incorrect and shouldn't be merged as is.

The real problem is, I think, with an API change in libselinux.
I don't know however how to fix that in a way that could be merged
mainstream.

Cheers,

-- 
Bruno Ducrot

-- Which is worse: ignorance or apathy?
-- Don't know.  Don't care.




More information about the Open-scap-list mailing list