[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Ovirt-devel] [patch] Even Better Exceptions For ruby-libvirt bindings



On Tue, 2008-04-01 at 00:26 -0400, Mohammed Morsi wrote:
> David Lutterkort wrote:
> > 
> > an exception is allocated every time there is an error check. Can you
> > change it so that create_error is only called when there actually is a
> > need to throw an exception ? _E should be changed so that the above use
> > looks something like
> >
> >         _E(r < 0, e_RetrieveError, "virConnectGetVersion", conn);
> >   
> I was actually thinking about the _E and the continuous exception 
> creation as well and I don't think its an issue.

No idea what I was on when I wrote the above - you are perfectly right.

David




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]