[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Ovirt-devel] create-wui-appliance.sh: useful script!



Jim Meyering wrote:
> Hi Perry,
> 
> Thanks for the create-wui-appliance.sh script.
> It nicely eliminates several annoyingly manual steps.
> 
> Here are some small changes.  I've tested the result.
> Barring objections I'll push soon.
> 
> 	create-wui-appliance.sh: mostly-minor changes
> 	* wui-appliance/create-wui-appliance.sh: Remove unnecessary
> 	quotes in var=... RHS.  Remove unnecessary braces in ${VAR_NAME}/.
> 	Don't redirect function definition.  Use 'cat<<EOF' instead of repeated
> 	echo.  Add quotes around various $VAR uses, in case they contains shell
> 	meta-characters.  Hoist default arch and image dir definitions,
> 	and use them in usage.  Use bash's built-in "getopts" function.
> 	Accept "-h" option (for help).  Upon usage error, refer to -h,
> 	rather than printing full usage.

Thanks for cleaning this up.  :)  I had no idea there was getopt for
bash...  I've been parsing script cmdline args manually for years.

Lots of other good techniques in here for me to absorb too.

ACK

Perry



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]