[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Ovirt-devel] [PATCH] create-wui-appliance.sh: minor fixes



Jim Meyering wrote:
"Perry N. Myers" <pmyers redhat com> wrote:
Changes look fine so ACK.  One question though, why did you change
kickstart to lowercase and not IMGDIR?

Hi Perry,

Good point.
I didn't notice that there was another non-const variable
that was upper case.  I noticed/changed KICKSTART because I was
already fixing a problem with it.
Even so, I had qualms about mixing syntax-only changes
with bug-fixing ones.  But this is nothing serious or deep,
so it's no big deal to obscure the fixes slightly.

Also spotted an unused "ISO".

If no one objects, I'll push the following instead:

Looks good to me, go ahead and push.

Perry


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]