[Ovirt-devel] [PATCH] Fix broken js cause by svg widget. (revised)

[Scott Seago]

Jason Guiditta wrote:
> This just disables the calls to svg widget within any flexigrids, which is the cause of checkboxes not appearing, details not showing, and other such unpleasantness.  Next step would be to replace these bits with css bar graphs, which will hopefully make it in shortly, but as this breakage is annoying, thought I would do a quick fix.  Left it as commented out since the very next step is to replace with css and I want to easily see what I am replacing.
> ---
>  wui/src/app/views/graph/_load_graph.rhtml |   16 ++++++++--------
>  1 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/wui/src/app/views/graph/_load_graph.rhtml b/wui/src/app/views/graph/_load_graph.rhtml
> index f6827b2..6678e90 100644
> --- a/wui/src/app/views/graph/_load_graph.rhtml
> +++ b/wui/src/app/views/graph/_load_graph.rhtml
> @@ -5,10 +5,10 @@ function load_widget(div, target){
>    var id = $(div).html();
>    $(div).html('');
>    $(div).addClass("load_graph");
> -  $(div).svg();
> -  var svg = svgManager.getSVGFor(div);
> +  //$(div).svg();
> +  //var svg = svgManager.getSVGFor(div);
>    var params = { id:1, type:"json", timeframe:"7 days", isJSON:true};
> -  $.getJSON("<%= url_for :controller => 'graph', :action => 'load_graph_data' %>/" + id + "?target=" + target, params,
> +  /*$.getJSON("<%= url_for :controller => 'graph', :action => 'load_graph_data' %>/" + id + "?target=" + target, params,
>               function(response){
>                    svg.graph.noDraw();
>                     svg.graph.chartFormat('white', 'white').
> @@ -25,10 +25,10 @@ function load_widget(div, target){
>                     svg.graph.legend.show(false);
>                     svg.graph.redraw();
>               }
> -   );
> +   );*/
>  //   $(div).children().filter("svg").attr('height', 25).attr('width', 200);
> -   $(div).children().filter("svg").attr("height").baseVal.value = 25;
> -   $(div).children().filter("svg").attr("width").baseVal.value = 200;
> +   //$(div).children().filter("svg").attr("height").baseVal.value = 25;
> +   //$(div).children().filter("svg").attr("width").baseVal.value = 200;
>  };
>  
>  // invoked when a row containing a load widgit is selected
> @@ -38,11 +38,11 @@ function toggle_load_widget(div, state){
>      color = '#D5EFFC'; 
>    }
>      
> -  var graph = svgManager.getSVGFor(div).graph;
> +  /*var graph = svgManager.getSVGFor(div).graph;
>    graph.noDraw().chartFormat(color, color);
>    graph.xAxis.line(color, 0);
>    graph.yAxis.line(color, 0);
> -  graph.redraw();
> +  graph.redraw();*/
>  };
>  
>  function load_widget_select(selected_row)
>   
works for me
ACK