[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Ovirt-devel] [PATCH] protect against shell meta-characters in working directory name



I doubt anyone using these tools will be clueless enough to do
so from a polluted (e.g., space-containing) working directory,
but better safe than sorry.  And if someone ever does,
this way we won't get a bug report about it.

Untested.

>From dcb8024406297dc33c95c2b924a6f61d7ec27792 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering redhat com>
Date: Mon, 18 Aug 2008 22:13:06 +0200
Subject: [PATCH] protect against shell meta-characters in working directory name

---
 ovirt-host-creator/Makefile |    2 +-
 wui-appliance/Makefile      |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/ovirt-host-creator/Makefile b/ovirt-host-creator/Makefile
index eba1f15..bd30f49 100644
--- a/ovirt-host-creator/Makefile
+++ b/ovirt-host-creator/Makefile
@@ -18,7 +18,7 @@ ovirt.iso: ovirt.ks common-install.ks common-pkgs.ks common-post.ks repos.ks
 	../common/rpm-compare.py GE 0 livecd-tools 017.1 1
 	mkdir -p tmp
 	livecd-creator --skip-minimize -c ovirt.ks -f ovirt \
-	  --tmpdir=$$(pwd)/tmp --cache=$(YUMCACHE)
+	  --tmpdir="$$(pwd)/tmp" --cache="$(YUMCACHE)"

 tar: clean ovirt.iso
 	mkdir -p $(NV)
diff --git a/wui-appliance/Makefile b/wui-appliance/Makefile
index 760b6ff..ba57aea 100644
--- a/wui-appliance/Makefile
+++ b/wui-appliance/Makefile
@@ -8,7 +8,7 @@ appliance-compressed: $(NAME)-sda.qcow
 $(NAME)-sda.raw: wui-devel.ks common-install.ks common-pkgs.ks common-post.ks repos.ks
 	mkdir -p tmp
 	appliance-creator --config wui-devel.ks --name $(NAME) \
-	  --tmpdir=$$(pwd)/tmp --cache=$(YUMCACHE)
+	  --tmpdir="$$(pwd)/tmp" --cache="$(YUMCACHE)"

 $(NAME)-sda.qcow: $(NAME)-sda.raw
 	# FIXME add --compress option to appliance-creator
--
1.6.0.4.g750768


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]