[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Ovirt-devel] [PATCH] separate test results log



Alan Pevec <apevec redhat com> wrote:
>>> +test -n "$1" && RESULTS="$1" || RESULTS="results.log"
>>
>> You can drop some of those quotes (in the name of removing
>> unnecessary syntax):
>>
>>   test -n "$1" && RESULTS=$1 || RESULTS=results.log
>
>>> +   cd /usr/share/ovirt-wui && rake test" > $RESULTS 2>&1 \
>>> +  || die "wui tests failed"
>
>>     cd /usr/share/ovirt-wui && rake test" > "$RESULTS" 2>&1 \
>
> ok, BTW, that was copy/paste from libvirt/autobuild.sh so you might want to suggest the same fix "upstream" :)

Thanks.
I've just posted a patch there.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]