[Ovirt-devel] [PATCH] oVirt autobuild / rpm inclusion (fix)

Daniel P. Berrange berrange at redhat.com
Thu Aug 21 20:01:03 UTC 2008


On Thu, Aug 21, 2008 at 03:17:41PM -0400, Mohammed Morsi wrote:
>  
>  # make oVirt RPMs available as autobuild output
>  # TODO fix oVirt Makefiles to honour ~/.rpmmacros (autobuild sets that up)
> -ln tmp/ovirt/*.rpm $AUTOBUILD_PACKAGE_ROOT/rpm
> +rm -f $AUTOBUILD_PACKAGE_ROOT/rpm/*.rpm
> +ln -s `pwd`/tmp/ovirt/*.rpm $AUTOBUILD_PACKAGE_ROOT/rpm/

NACK.

Hardlinking is the correct way todo this. symlinking increasing the I/O
overhead, and prevents autobuild from using hardlinks for its archive
and when publish to the web root.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|




More information about the ovirt-devel mailing list