[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Ovirt-devel] [PATCH] Added a configuration generation for managed nodes. It takes as input a





Scott Seago wrote:
David Lutterkort wrote:
On Thu, 2008-08-21 at 13:12 -0400, Darryl L. Pierce wrote:

The subject of the patch is mangled, and it would be good to have a
little more description, too.

I'd ACK this if the description was fixed, and the spurious change to
application.rb removed.

---
 wui/src/app/controllers/application.rb             |    2 +-
 wui/src/lib/managed_node_configuration.rb          |   53 +++++++++++
 wui/src/test/fixtures/hosts.yml                    |    9 ++
 wui/src/test/fixtures/nics.yml                     |    7 +-
 wui/src/test/fixtures/pools.yml                    |    4 +
.../functional/managed_node_configuration_test.rb | 98 ++++++++++++++++++++
 6 files changed, 171 insertions(+), 2 deletions(-)
 create mode 100644 wui/src/lib/managed_node_configuration.rb
create mode 100644 wui/src/test/functional/managed_node_configuration_test.rb

diff --git a/wui/src/app/controllers/application.rb b/wui/src/app/controllers/application.rb
index d653171..b27ddbe 100644
--- a/wui/src/app/controllers/application.rb
+++ b/wui/src/app/controllers/application.rb
@@ -35,7 +35,7 @@ class ApplicationController < ActionController::Base
   before_filter :is_logged_in
def is_logged_in - redirect_to (:controller => "login", :action => "login") unless get_login_user + redirect_to(:controller => "login", :action => "login") unless get_login_user
   end

Seems to have slipped in by accident.

Perhaps a different patch would have been appropriate here, but this change was made deliberately to avoid the ruby warning about the space between method name and open paren. Then again, such a trivial change should probably just be pushed directly without needing an ACK -- and on top of that, I believe this same change already came through another patch last week.

yes, http://git.et.redhat.com/?p=ovirt.git;a=commitdiff;h=9fc192c43692ed2315d331d0b9314059551b4923
so just remove that part from your patch


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]