[Ovirt-devel] [PATCH server] Changed how taskomatic handles a Cobbler image record.

[Perry Myers]

Darryl L. Pierce wrote:
> On Fri, Dec 19, 2008 at 09:39:34PM -0500, Perry Myers wrote:
>> Darryl L. Pierce wrote:
>>> It will now incrementally pull out the protocol, authentication details,
>>> hostname or ip address, export path and filename for the image record.
>> This patch works fine for urls like:
>>
>> nfs://192.168.50.2/cobblernfs/winxp.iso
>>
>> but does not work for
>>
>> nfs://192.168.50.2:/cobblernfs/winxp.iso
>>
>> And according to the cobbler site:
>> https://fedorahosted.org/cobbler/wiki/AllAboutImages
>>
>> The format for nfs urls should look like:
>> nfs://user@host:/path/to/foo.iso --image-type=iso
> 
> Okay, doing a quick lookup, the above is valid but discouraged so
> long as the protocol is specified.[1] I'll have a quick look in 
> Cobbler to make sure such a case is handled. But in oVirt we'll 
> raise an exception if no protocol is specified and there's a colon 
> and no port.
> 
> [1] http://labs.apache.org/webarch/uri/rfc/rfc3986.html#port

iirc, mpdehaan told me that that field is completely unvalidated

so you could put ANY string you want in there... so I think what's 
important for us to do is to make sure we handle all of the expected 
normal formats...  So just make sure we're doing the proper validation on 
our end.

And you might want to raise an issue with the cobbler team to see if they 
can put some validation in the field

Perry



-- 
|=-        Red Hat, Engineering, Emerging Technologies, Boston        -=|
|=-                     Email: pmyers at redhat.com                      -=|
|=-         Office: +1 412 474 3552   Mobile: +1 703 362 9622         -=|
|=- GnuPG: E65E4F3D 88F9 F1C9 C2F3 1303 01FE 817C C5D2 8B91 E65E 4F3D -=|