[Ovirt-devel] [PATCH] Fix the attributes for the log rotate script.

Chris Lalancette clalance at redhat.com
Wed Jul 9 20:35:36 UTC 2008


Darryl L. Pierce wrote:
> Signed-off-by: Darryl L. Pierce <dpierce at redhat.com>
> ---
>  wui/src/host-browser/host-browser.rb |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/wui/src/host-browser/host-browser.rb b/wui/src/host-browser/host-browser.rb
> index e66493d..3b3d0cd 100755
> --- a/wui/src/host-browser/host-browser.rb
> +++ b/wui/src/host-browser/host-browser.rb
> @@ -217,6 +217,8 @@ class HostBrowser
>              host.cpus << detail
>           end
>  
> +         host.save
> +
>          return host
>      end

We definitely need this patch, otherwise "updates" to the host (i.e. adding more
memory, etc.) don't get committed to the database.  Two things:

1)  The subject for this patch seems wrong
2)  I think putting the "host.save" at this point in "write_host_info" is the
correct thing to do.  We should probably remove the one further up in the
"Host.create()" section, since you are duplicating going to the database in that
case.

Chris Lalancette




More information about the ovirt-devel mailing list