[Ovirt-devel] [PATCH] Refactored the ovirt-identify codebase, and added NIC info during the identify phase.

[Darryl L. Pierce]

Perry N. Myers wrote:
>> Since you are moving chunks of code around, it's good opportunity to 
>> simply run
>> indent-libvirt from libvirt's HACKING - I guess it makes sense to 
>> adopt libvirt's
>> coding guidelines for oVirt C code.
> 
> Yes, lets do that.

I agree. I'll do that and send out an updated patch.

>> It might be a good idea to use virBuffer API, also mentioned in 
>> libvirt's HACKING file.
> 
> Also a good idea, since we already have a hard dependency on libvirt 
> anyhow.

Same here.

>> As discussed on IRC, I'm a bit worried about adding dependency on HAL, 
>> since it's announced to be replaced with DeviceKit and from the thread 
>> on the HAL list[1] it's not clear to me that compat HAL API will be 
>> maintained in the future.
> 
> I think the idea here is that hal is a short term solution to hardware 
> identification.  In the long term we should be getting everything we 
> need from libvirt APIs.  So what we need to do is make a laundry list of 
> all of the things we need to have added into libvirt to get us to that 
> point.
> 
> Darryl, since you've been working on the hardware enum stuff, can you 
> get this list together?

Will do. I'll send out a list in the next day or so with a list based on 
what we've talked about so far.

-- 
Darryl L. Pierce, Sr. Software Engineer
Red Hat, Inc. - http://www.redhat.com/
oVirt - Virtual Machine Management - http://www.ovirt.org/
"What do you care what other people think, Mr. Feynman?"