[Ovirt-devel] [PATCH] Test System Updates

[Perry N. Myers]

Mohammed Morsi wrote:
> Perry N. Myers wrote:
>> Mohammed Morsi wrote:
>>> Took these fixes, and our discussion about how the 2nd stage 
>>> autobuild is unnecessary and came up with a simpler autobuild script 
>>> / kickstart that runs the 2nd stage tests (eg site accessibility and 
>>> rake tests) through ssh. When testing this, I noticed some of the 
>>> rake tests failed, I believe it due to recent code changes, and will 
>>> look at resolving them once this autobuild stuff is committed. In 
>>> addition to the rrd test data generation and usage code in the 
>>> patched, I began looking into how we can add some test data to the 
>>> rh-dirsrv ldap server running on the ovirt wui appliance. I'm not a 
>>> 100% sure yet, but I might be able to add a ldif file with test data 
>>> to the appliance via a kickstart script and then configure the server 
>>> / ovirt to use a path that points to it.
>>>
>>>   -Mo
>>>
>>>
>>
>> Comments inline...  I think Alan has made some of these comments 
>> already, but just to make sure...
>>
>>> -#run tests
>>> -cd wui/src/
>>> -rake db:migrate
>>> -rake test
>>> +echo "Running oVirt Autobuild"
>>> +
>>> +# create appliance
>>> +./build-all.sh -ac
>>
>> With Alan's changes to build-all, pungi no longer init's by default.  
>> I think we should init manually once on harpoon, and then do:
>>
>> ./build-all.sh -acp update
>>
>> to update pungi for each run.
>>
>>> +
>>> +while : ; do
>>> +    status=`virsh domstate ovirt-appliance`
>>> +    if [ -f /etc/libvirt/qemu/ovirt-appliance.xml -a "$status" = 
>>> "shut off" ]; then
>>> +        break
>>> +    fi
>>> +    sleep 10
>>> +done
>>
>> No need for a loop here since with Alan's patch appliance creation is 
>> synchronous.
>  From what I can tell (unless this has changed w/ the latest patch, 
> which I thought it didn't) the creation of the appliance on the host 
> side is synchronous, but when the appliance starts up (eg build all says 
> 'run virt-viewer to view output') and Fedora being installed, the 
> build-all command returns. I need to wait until this install process is 
> a 100% complete, before continuing and thus the loop is neccessary (once 
> again, basing this on what I observed, correct me if I am wrong).

It has changed with Alan's latest patch.  build-all now installs the 
appliance using livecd-creator, so at the end of the build-all script you 
have a working appliance image.  The install is no longer done on a live vm.

So you can remove this loop assuming Alan's patch gets in.

Perry