[Ovirt-devel] [PATCH] move collectd runlevel to start after libvirt

[Hugh O. Brock]

On Thu, Jun 05, 2008 at 06:02:37PM +0200, Alan Pevec wrote:
> as reviewer kindly pointed out, we need to create chkconfig.d first
> and this all must happen in %post not initscript!
>
>
> diff --git a/ovirt-host-creator/common-post.ks b/ovirt-host-creator/common-post.ks
> index cc64b80..833050a 100644
> --- a/ovirt-host-creator/common-post.ks
> +++ b/ovirt-host-creator/common-post.ks
> @@ -344,7 +344,6 @@ start() {
>             -e "s/@COLLECTD_PORT@/$SRV_PORT/" $collectd_conf.in \
>             > $collectd_conf \
>           || die "Failed to write $collectd_conf"
> -        service collectd restart
>     fi
>
>     success
> @@ -364,6 +363,10 @@ EOF
> chmod +x /etc/init.d/ovirt
> chkconfig ovirt on
>
> +mkdir -p /etc/chkconfig.d
> +echo "# chkconfig: 345 98 02" > /etc/chkconfig.d/collectd
> +chkconfig collectd on
> +
> echo "Setting up libvirt interfaces"
> # make libvirtd listen on the external interfaces
> sed -i -e 's/^#\(LIBVIRTD_ARGS="--listen"\).*/\1/' /etc/sysconfig/libvirtd

ACK... 

I guess we can't assume that chkconfig install auto-creates /etc/chkconfig.d?

--H