[ovirt-devel][PATCH] Add Status and error handling to Stats stuff

Chris Lalancette clalance at redhat.com
Fri Jun 6 15:56:54 UTC 2008


mark wagner wrote:
> Added code to check validity of pathname to rrdfile.
> Added new enum for StatsStatus
> Added new member to StatsDataList to hold status information
> ---
>   wui/src/app/util/stats/Stats.rb         |   36 ++++++++++++++++++++++--------
>   wui/src/app/util/stats/StatsDataList.rb |    7 +++++-
>   wui/src/app/util/stats/StatsTypes.rb    |   21 ++++++++++++++++++
>   wui/src/app/util/stats/statsTest.rb     |   17 ++++++++++----
>   4 files changed, 65 insertions(+), 16 deletions(-)

We hashed this out on IRC, but I asked the question of: what gets displayed in
the host details after this patch?  If there is no data, then we should just
display all 0's.  The important part is not to error.  mmorsi says that's what
happens at the moment, so I think he is just going to add a slight patch to log
to the log file.

Assuming that is the case, and the extra little patch goes in with this, ACK
from me.

Chris Lalancette




More information about the ovirt-devel mailing list