[Ovirt-devel] [PATCH] s3-memory-leak

Scott Seago sseago at redhat.com
Tue Jun 10 14:34:54 UTC 2008


Jason Guiditta wrote:
> The nav refresh was indeed the culprit of the recent memory leak (thanks
> Scott for helping track it down).  The way I was calling the refresh
> resulted in a closure that did not quite behave the way I thought it
> would.  I wasn't able to get it to quite do what I wanted tonight, so
> this patch simplifies the way we are doing it for now.  It should behave
> the same as before, minus the memory leak, but in the near future I will
> try and get it to work the way I originally wanted.
>
> -j
>   
Definitely an improvement. I'm still seeing one extra request per 
refresh period. In addition to the tree/fetch_json call, the top-level 
URL is being requested again. So, if you start at the dashboard, 
whatever pool you're looking at the full html response for the dashboard 
page is being requested. So we still have a leak, but it's much slower 
than before.

Scott




More information about the ovirt-devel mailing list