[Ovirt-devel] [PATCH] s3-memory-leak

[Jason Guiditta]

Scott Seago wrote:
> Jason Guiditta wrote:
>> The nav refresh was indeed the culprit of the recent memory leak (thanks
>> Scott for helping track it down).  The way I was calling the refresh
>> resulted in a closure that did not quite behave the way I thought it
>> would.  I wasn't able to get it to quite do what I wanted tonight, so
>> this patch simplifies the way we are doing it for now.  It should behave
>> the same as before, minus the memory leak, but in the near future I will
>> try and get it to work the way I originally wanted.
>>
>> -j
>>   
> Definitely an improvement. I'm still seeing one extra request per 
> refresh period. In addition to the tree/fetch_json call, the top-level 
> URL is being requested again. So, if you start at the dashboard, 
> whatever pool you're looking at the full html response for the 
> dashboard page is being requested. So we still have a leak, but it's 
> much slower than before.
>
> Scott
Yes, I should have listed that as a known behavior, but it was late  :)  
I don't know why there are two calls, but I would no longer classify 
this as a leak.  In my testing I found it to always issue the same 2 
calls per refresh no matter how many nodes were open or how long it sat, 
so I don't think there will be any more memory issues there.  I suspect 
it is just some behavior of the plugin that I did not understand, and 
will make sure it goes away on the rewrite, but I don't think it is 
worth pursuing at this point.

-j