[Ovirt-devel] PATCH: constrain storage_pool to avoid duplicate targets

Hugh O. Brock hbrock at redhat.com
Thu May 1 13:39:41 UTC 2008


On Thu, May 01, 2008 at 08:23:51AM -0500, steve linabery wrote:
> On Thu, May 1, 2008 at 8:05 AM, Hugh O. Brock <hbrock at redhat.com> wrote:
> >
> >  >                  <div class="data-table-column">
> >  > -                  <strong>Choose From Storage in <%= @hardware_pool.parent.name %></strong>
> >  > +<strong>FIX ME: hardware_pool parent attribute</strong>
> >  > +<!--                  <strong>Choose From Storage in < @hardware_pool.parent.name ></strong>
> >  > +-->
> >
> >  What are we missing here?
> >
> >  Thanks,
> >  --Hugh
> >
> 
> The 'FIXME' allows storage/new.rhtml and storage/new2.rhtml to be
> served. Those pages are currently broken because they are referencing
> an attribute called 'parent' in the HardwarePool object that does not
> exist.
> 
> Since I don't know how where the model is headed on this particular
> point, I thought it best to just put a FIXME placeholder in those
> rhtml files to allow mongrel to serve them.
> 
> I should have split this out into a different patch, I guess, since it
> doesn't have anything to do with the uniqueness constraint issue, no?
> 
> Hope this answers your question.
> 

No, that seems fine, thanks!

ACK

--Hugh




More information about the ovirt-devel mailing list