[Ovirt-devel] [PATCH] A few specfile tweaks

[Jim Meyering]

Jim Meyering <jim at meyering.net> wrote:
> Ian Main <imain at redhat.com> wrote:
>> D'oh, need this too..  Consider it an addendum :)
>>
>> diff --git a/wui-appliance/common-post.ks b/wui-appliance/common-post.ks
>> index 3bd6b4d..d50436a 100644
>> --- a/wui-appliance/common-post.ks
>> +++ b/wui-appliance/common-post.ks
>> @@ -34,7 +34,7 @@ cat > /etc/init.d/ovirt-wui-first-run << \EOF
>>  start() {
>>  	echo -n "Starting ovirt-wui-first-run: "
>>
>> -	/usr/bin/ovirt-wui-install > /var/log/ovirt-wui-first-run.log 2>&1
>> +	/usr/sbin/ovirt-wui-install > /var/log/ovirt-wui-first-run.log 2>&1
>
> Hi Ian,
>
> You could also just drop the leading "/usr/sbin/", since the PATH
> is set via the preceding ". /etc/init.d/functions" line.
>
> This is another good reason to avoid those absolute prefixes when possible.
>
> Speaking of that, I still have a patch that removes a whole bunch of them.
> I'll rebase it and post on Monday.

I've been doing this little by little over the last month or two...
If you're interested only in some parts, tell me which and I'll extract them:

  - factor out some duplication
  - split long lines
  - remove /usr/sbin, /usr/bin, etc. prefixes
  - a couple misc things like use printf rather than echo -e

Until today, the middle change-set accidentally removed some
trailing blanks (not good to mix that sort of change with a "real" one),
so today after the main rebase (git rebase master) I ran
"git rebase -i master" from my topic branch, selected the middle
change-set and actually re-added those trailing blanks.

Avoiding this sort of extra work is one of the reasons I'd like
to remove all trailing blanks.

What sort of testing would you like?

Jim
-------------------