[Ovirt-devel] [PATCH] graphs for detail pane of hosts take 2

Jason Guiditta jguiditt at redhat.com
Fri May 23 20:03:50 UTC 2008


Sorry, forgot to update before I made that last patch, there would be a
cnlfict, this one should better. Reposting notes if you want to ignore
the last one:

Besides adding the new graphs, I also added a param that can be passed
into the js in _graph.rhtml to allow you to specify a css class for the
svg container div.  This means instead of having to have id-based
classes to set height and width (so the svg shows up) we can reuse
classes whenever it makes sense (for example, all detail pane graphs
should be the same size, etc).  Also, for some reason, I did not hit the
js error thrown in the background by some of the other graphs.  I chalk
this up to something being different in the returned json (I am using a
different controller) but haven't traked it down quite yet. I'll keep
looking, but wanted to get the main patch out in the meantime.

-j
-------------- next part --------------
A non-text attachment was scrubbed...
Name: s2-host-graph-redux.patch
Type: text/x-patch
Size: 6443 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/ovirt-devel/attachments/20080523/5033aaa7/attachment.bin>


More information about the ovirt-devel mailing list