[Ovirt-devel] Re: [PATCH node] Added support for local storage configuration.

[Alan Pevec]

Darryl L. Pierce wrote:
> +++ b/scripts/ovirt-config-storage
...
> +if [ "$1" == "AUTO" ]; then
> +    DRIVE=$OVIRT_VOL
OVIRT_VOL -> OVIRT_INIT  (will be set by ovirt-early when parsing boot params)

vars set by ovirt-early with partition sizes are:
OVIRT_VOL_BOOT
OVIRT_VOL_SWAP
OVIRT_VOL_ROOT
OVIRT_VOL_CONFIG
OVIRT_VOL_LOGGING

This part was modified in the follow up patch, so Jim please amend: OVIRT_(.*)_SIZE -> OVIRT_VOL_\1

+BOOT_SIZE=${OVIRT_BOOT_SIZE=$default_boot_size}
+ROOT_SIZE=${OVIRT_ROOT_SIZE=$default_root_size}
+LOGGING_SIZE=${OVIRT_LOGGING_SIZE=$default_logging_size}
+CONFIG_SIZE=${OVIRT_CONFIG_SIZE=$default_config_size}
+
 if [ "$1" == "AUTO" ]; then
+    # In "AUTO" mode, OVIRT_VOL should be defined in the environment.
     DRIVE=$OVIRT_VOL
-    if [ -n "$OVIRT_BOOT_SIZE" ]; then BOOT_SIZE=$OVIRT_BOOT_SIZE; else BOOT_SIZE=256; fi
-    if [ -n "$OVIRT_ROOT_SIZE" ]; then ROOT_SIZE=$OVIRT_ROOT_SIZE; else ROOT_SIZE=256; fi
-    if [ -n "$OVIRT_LOGGING_SIZE" ]; then LOGGING_SIZE=$OVIRT_LOGGING_SIZE; else LOGGING_SIZE=512; fi
-    if [ -n "$OVIRT_CONFIG_SIZE" ]; then CONFIG_SIZE=$OVIRT_CONFIG_SIZE; else CONFIG_SIZE=5; fi


> diff --git a/scripts/ovirt-firstboot b/scripts/ovirt-firstboot
...
Darryl, please drop this ovirt-firstboot modification from the patch, I have separate patch which uses is_auto_install function instead