[Ovirt-devel] Re: [PATCH server] network integration into ovirt server db and wui

Scott Seago sseago at redhat.com
Fri Oct 31 21:47:23 UTC 2008


Testing the revised patch now.

Mohammed Morsi wrote:
> Hugh O. Brock wrote:
>   
>> On Fri, Oct 31, 2008 at 11:35:36AM -0400, Mohammed Morsi wrote:
>>   
>>     
>>> 1. Remove 'validate' method, replace w/ 'validates_presence_of',
>>> 'validate_format_of' where we can
>>>     
>>>       
> I can take care of this bit
>
>   
OK this is done.
>>> 2. Change ManageNodeConfiguration bit, to use new network model / schema
>>>     
>>>       
> The only thing this depends on is the model changes I did, which was
> based on http://www.ovirt.org/page/Redesigned_Network_Configuration. If
> someone who knows this bit more that I do can take care of it, it would
> speed things up
>
>   
I'm not sure what the state of this is, and I'm not sure how to test it. 
If there's anything here that must be in the release, hopefully dpierce 
can confirm.

>>> 3. Disable type selection for 'edit network' form
>>>     
>>>       
> Small, quick fix that I can take care of
>
>   
This is done.
>>> 5. Add ip address information to the network details pane
>>> 6. Add nic / bonding information to host details pane
>>>     
>>>       
> Both these items should be fairly straightforward and I can take care of.
>
>   
Basic summary of IP address is showing (i.e. the actual IP address) but 
the other metadata isn't there. The only way you can see it is the edit 
form -- but someone without edit rights wouldn't be able to do that. I 
think this is good enough for this patch and release, but we need to go 
back and make all of the data available in some sort of view page -- 
either via a flexigrid on the details pane or via a 'details' dialog.

For 6) -- I'm not sure if NIC is showing up properly, as my current DB 
doesn't have any NICs for hosts, but in addition to just the name we 
need a way to show all the metadata.
For the bonding -- I can't create a bonding w/ a static IP VLAN. for 
dhcp it works. However,  the summary pane isn't giving me anything 
useful for the bonding metadata. it shows: 
'71bcc3d3-bc81-fe8d-bf93-e2fa9814ba54' instead of the name. And the 
additional metadata isn't available.

The points that need to be fixed before pushing here are 1) static IP 
vlan; 2) bonding field in details pane needs to show the proper name. 
The other parts can be fixed later.


>
>>> 8. Add usages multi-select box to create / edit network form
>>>     
>>>       
> Another straightforward item I can take care of
>
>   
Usage is in the form -- it's not showing up in details -- another one 
for post-release if there are no objections here.

so not yet ACK -- we need to fix:

1) ManagedNodeConfiguration bit -- I'm not sure about this one -- but my 
concern is without this fix networking will be completely broken on the 
nodes/VMs
2) static IP VLAN for bondings
3) host details pane needs to show the bonding name in the 'bonding' 
section.

Scott




More information about the ovirt-devel mailing list