[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Ovirt-devel] work around "*** ERROR: No build ID note found in..." on rawhide



"Daniel P. Berrange" <berrange redhat com> wrote:

> On Mon, Sep 08, 2008 at 03:26:23PM +0200, Jim Meyering wrote:
>> "Daniel P. Berrange" <berrange redhat com> wrote:
>> > On Mon, Sep 08, 2008 at 02:32:03PM +0200, Jim Meyering wrote:
>> >> --- a/ovirt-identify-node/Makefile
>> >> +++ b/Makefile.am
>> ...
>> >> +include release.mk
>> >>
>> >> -clean:
>> >> -	rm -rf $(OBJECTS) $(TARGET)
>> >> -
>> >> -$(TARGET): $(OBJECTS)
>> >> -	$(CC) -o $@ $(OBJECTS) $(LFLAGS)
>> >> -
>> >> -.PHONY: all clean
>> >> +pkg_name = ovirt-node
>> >> +.PHONY: tar
>> >> +tar: dist
>> >> +	tar xf $(distdir).tar.gz
>> >> +	mkdir -p rpm-build/BUILDROOT
>> >> +	tar zcvf rpm-build/$(NV).tar.gz $(NV)
>> >> +	cp version rpm-build
>> >> +	chmod -R u+rwx $(NV)
>> >> +	rm -rf $(NV)
>> >
>> > Do we really need to preserve this custom target  when automake
>> > provides a perfectly good 'make dist'. It just seems to be taking
>> > the tar.gz, extracting it, and then re-creating it with files having
>> > a rpm-build/  prefix which is just wierd. RPMs should be built from
>> > the real tar.gz automake provides.
>>
>> Not really, but since other things (see 5 other copies of included
>> release.mk) currently rely on that layout, this keeps my changes
>> small and relatively safe.
>
> Hmm, actually this is even more bizarre that I thought - it isn't
> actually creating the tar.gz with different prefix. Unless I'm
> missing something, can't it be simplified to
>
>> >> +tar: dist
>> >> +  cp $(distdir).tar.gz rpm-build/
>> >> +  cp version rpm-build

You're right.  It can certainly be simplified more.
However, we still do need to create the BUILDROOT sub-directory:

tar: dist
	mkdir -p rpm-build/BUILDROOT
	cp version $(distdir).tar.gz rpm-build

> Ultimately 'release.mk'; should just call 'make dist' and look
> in the top level dir to start with, but good idea to separate
> that change from the main re-factoring.
...
>
> ACK

Thanks for the speedy feedback.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]