[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Ovirt-devel] work around "*** ERROR: No build ID note found in..." on rawhide



Jim Meyering wrote:
> Anyhow, first things first.
> I have 4 change sets, three tiny ones and the autoconfication one.
>
> Autoconfiscation fixes the problem mentioned in the title.
> However note that you'll need the following small tweak to
> release/ovirt.mk in order to actually use it.
>
> diff --git a/ovirt.mk b/ovirt.mk
> index e9bff32..9717d14 100644
> --- a/ovirt.mk
> +++ b/ovirt.mk
> @@ -56,6 +56,8 @@ publish:
>  		if ! test -d $$dir ; then \
>  			$(MAKE) $$dir || exit 1 ; \
>  		fi ; \
> +		( cd $$dir; test ! -f Makefile.in && ./autogen.sh ); \
> +		( cd $$dir; test ! -f Makefile && ./configure ); \
>  		$(MAKE) -C $$dir $@ || exit 1 ; \
>  	done
>  	rm -f rpms
>   
I'm assuming that the autoconfiscate patch below is to be applied only
to the node side of things, correct? If that is the case, am I also
correct in saying that this will fail with our current oVirt setup since
ovirt-server and the other other repos don't currently have autogen.sh
scripts?

> diff --git a/autogen.sh b/autogen.sh
> new file mode 100755
> index 0000000..77fe883
> --- /dev/null
> +++ b/autogen.sh
> @@ -0,0 +1,57 @@
> +#!/bin/sh
> +# Run this to generate configure and Makefile
> +
> +srcdir=`dirname $0`
> +test -z "$srcdir" && srcdir=.
> +
> +THEDIR=`pwd`
> +(
> +  cd $srcdir
> +  die=0
> +
> +  (autoconf --version) < /dev/null > /dev/null 2>&1 || {
> +	  echo
> +	  echo "You must have autoconf installed."
> +	  echo "Download the appropriate package for your distribution,"
> +	  echo "or see http://www.gnu.org/software/autoconf";
> +	  die=1
> +  }
> +
> +  (libtool --version) < /dev/null > /dev/null 2>&1 || {
> +	  echo
> +	  echo "You must have libtool installed."
> +	  echo "Download the appropriate package for your distribution,"
> +	  echo "or see http://www.gnu.org/software/libtool";
> +	  die=1
> +  }
> +
> +  (automake --version) < /dev/null > /dev/null 2>&1 || {
> +	  echo
> +	  die=1
> +	  echo "You must have automake installed."
> +	  echo "Download the appropriate package for your distribution,"
> +	  echo "or see http://www.gnu.org/software/automake";
> +  }
> +
> +  test $die = 1 && exit 1
> +
> +  test -f ovirt-identify-node.h || {
> +	  echo "You must run this script in the top-level directory"
> +	  exit 1
> +  }
>   
Should this be test ! -f ovirt-identify-node.h? The way it is now, it
fails if that file (which is in the ovirt-identify-node subdir) isn't
present in the current directory.

Other than that it looks good as far as I can tell; as after I applied
that patch and made the aforementioned change I was able to run
"autogen.sh" and "make" to produce the ovirt-node rpms.

   -Mo


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]