[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Ovirt-devel] [PATCH] [ovirt-node] autobuild.sh



On Wed, Sep 10, 2008 at 08:44:02AM -0400, Mohammed Morsi wrote:
> ---
>  autobuild.sh |   29 +++++++++++++++++++++++++++++
>  1 files changed, 29 insertions(+), 0 deletions(-)
>  create mode 100755 autobuild.sh
> 
> diff --git a/autobuild.sh b/autobuild.sh
> new file mode 100755
> index 0000000..835212e
> --- /dev/null
> +++ b/autobuild.sh
> @@ -0,0 +1,29 @@
> +#!/bin/sh
> +#oVirt node autobuild script
> +#
> +# Copyright (C) 2008 Red Hat, Inc.
> +#
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; version 2 of the License.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write to the Free Software
> +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
> +# MA  02110-1301, USA.  A copy of the GNU General Public License is
> +# also available at http://www.gnu.org/copyleft/gpl.html.
> +
> +set -e
> +set -v
> +
> +echo "Running oVirt Node Autobuild"
> +./autogen.sh --prefix=$AUTOBUILD_INSTALL_ROOT
> +./configure

autogen.sh will run configure - running it again is blowing away the
--prefix you set a line earlier.

You should also 'make', (possibly 'make test') and 'make install'

> +make publish
> +
> +ln -f rpm-build/*.rpm $AUTOBUILD_PACKAGE_ROOT/rpm

Same comments as per other modules


Basically I expect that autobuild.sh for any autotools based app should
look pretty much like this:

http://gtk-vnc.codemonkey.ws/hg/outgoing.hg/file/f1d5c8fae2e9/autobuild.sh

Add in a 'make test' command before 'make install' if the app has a test
suite

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]