[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Ovirt-devel] [PATCH] [ovirt-node] autobuild.sh



Mohammed Morsi wrote:
> diff --git a/autogen.sh b/autogen.sh
> index 85352f0..b8828fe 100755
> --- a/autogen.sh
> +++ b/autogen.sh
> @@ -49,6 +49,7 @@ THEDIR=`pwd`
>    autoheader
>    automake --add-missing
>    autoconf
> +  ./configure "$@"
>  )

Dunno anything about autobuild.sh, so I'll skip that for now.  For autogen.sh,
we might want to follow the pattern of libvirt; the reason (I believe) is so
that you can build into a different subdirectory.  The pattern is basically:

srcdir=`dirname $0`
test -z "$srcdir" && srcdir=.
THEDIR=`pwd`
cd $srcdir

...

automake
autoconf

cd $THEDIR

$srcdir/configure "$@" && {
    echo
    echo "Now type 'make' to compile libvirt."


I'll ACK a patch that does essentially that.

-- 
Chris Lalancette


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]