[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Ovirt-devel] Re: [PATCH] added ability to reprovision vm via edit vm form



Mohammed Morsi wrote:
---
 wui/src/app/controllers/vm_controller.rb |   73 +++++++++++++++++++++++++-----
 wui/src/app/views/vm/_form.rhtml         |    6 ++-
 2 files changed, 65 insertions(+), 14 deletions(-)


This all looks good so far, but I think there's still something missing.
From what I see here, I don't think the cobbler system is being created
in the reprovisioning case. Right the cobbler system is created in taskomatic in the create_vm action, but this won't be run in the reprovisioning case. It's not completely obvious how we'd resolve this, but we need to create and/or modify the cobbler system before restarting the VM.

Darryl -- from the cobbler point of view, what action is required when a cobbler profile is changed for a system -- do we just edit the cobbler system? i.e. retrieve it by name (UUID), and modify, or do we have to delete it and recreate one?

In any case, we'll need an explicit taskomatic task to be run before restarting the VM -- and this needs to happen any time the provisioning information is changed -- but it should probably not happen when we're not reprovisioning.

Scott


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]