[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Ovirt-devel] [PATCH] Added the appliance-recipe code from the acex repo



On Fri, 2008-08-22 at 10:47 -0400, bkearney redhat com wrote:
> From: root <root localhost localdomain>

I haven't tried this out, just read through it, and only have some minor
comments that could also be taken care of post commit.

> diff --git a/appliance-recipe/README.rdoc b/appliance-recipe/README.rdoc
> new file mode 100644
> index 0000000..7b981ac
> --- /dev/null
> +++ b/appliance-recipe/README.rdoc
> @@ -0,0 +1,17 @@
> += Pligg Recipe
> +This example will help to build a Pligg Appliance
> +In order to do this, please do the following:
> +
> +* Download Pligg Beta 9.9.0 from www.pligg.com. Put it into the
> +sources directory
> +* execute rake pligg_rpm. This will build an RPM from the 
> +distribuition.
> +* exeucte rake appliance_rpm. This will build an rpm for the recipe

We should mention OVirt here, not Pligg ;)

> diff --git a/appliance-recipe/appliances/ovirt/files/ovirt-wui-dev b/appliance-recipe/appliances/ovirt/files/ovirt-wui-dev
> new file mode 100644
> index 0000000..54970bb
> --- /dev/null
> +++ b/appliance-recipe/appliances/ovirt/files/ovirt-wui-dev
> +start() {
> +    echo -n "Starting ovirt-wui-dev: "
> +    dnsmasq -i eth1 -F 192.168.50.6,192.168.50.252 \
> +        -G 00:16:3e:12:34:57,192.168.50.3 -G 00:16:3e:12:34:58,192.168.50.4 \
> +        -G 00:16:3e:12:34:59,192.168.50.5 \
> +        -s priv.ovirt.org \
> +        -W _ovirt._tcp,management.priv.ovirt.org,80 \
> +        -W _ipa._tcp,management.priv.ovirt.org,80 \
> +        -W _ldap._tcp,management.priv.ovirt.org,389 \
> +        -W _collectd._tcp,management.priv.ovirt.org,25826 \
> +        -W _identify._tcp,management.priv.ovirt.org,12120 \
> +        --enable-tftp --tftp-root=/var/lib/tftpboot -M pxelinux.0 \
> +        -O option:router,192.168.50.2 -O option:ntp-server,192.168.50.2 \
> +        --dhcp-option=12 \
> +        -R --local /priv.ovirt.org/ --server 192.168.122.1

Not directly related to appliance building, but this should go into its
own config file, so that it can be adapted locally; makes deployment of
the appliance much more flexible.

> diff --git a/appliance-recipe/appliances/ovirt/files/ovirt.repo b/appliance-recipe/appliances/ovirt/files/ovirt.repo
> new file mode 100644
> index 0000000..c5d60cd
> --- /dev/null
> +++ b/appliance-recipe/appliances/ovirt/files/ovirt.repo
> @@ -0,0 +1,5 @@
> +[ovirt]
> +name=ovirt
> +baseurl=http://ovirt.org/repos/ovirt/9/$basearch/
> +enabled=1
> +gpgcheck=0

This _could_ go into a yumrepo resource in the puppet manifest.

> diff --git a/appliance-recipe/appliances/ovirt/ovirt.pp b/appliance-recipe/appliances/ovirt/ovirt.pp
> new file mode 100644
> index 0000000..6c8a3f4
> --- /dev/null
> +++ b/appliance-recipe/appliances/ovirt/ovirt.pp
> @@ -0,0 +1,154 @@

> +# Information about our appliance
> +$appliance_name 	= "OVirt Web UI"
> +$appliance_version 	= "0.0.1"
> +$ff_profile_dir 	= "uxssq4qb.ovirtadmin"
> +$principal 			= "ovirtadmin"
> +$realm 				= "PRIV.OVIRT.ORG"
> +$password 			= "ovirt"
> +$cron_file 			= "/etc/cron.hourly/ovirtadmin.cron"
> +$ktab_file 			= "/usr/share/ovirt-wui/ovirtadmin.tab"

Tab issues ?

> +file_replacement{"nat_forwarding" :  
> +					file => "/etc/sysctl.conf",
> +					pattern => "^net.ipv4.ip_forward = .*",
> +					replacement => "net.ipv4.ip_forward = 1",
> +					notify => Service[network]	,					
> +}

Augeas 0.3.1 supports sysctl.conf :)

David



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]