[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Ovirt-devel] [PATCH node-image] Fix %post for pxe pkg to succeed regardless of whether or not cobbler is present



Perry Myers wrote:
> diff --git a/ovirt-node-image.spec b/ovirt-node-image.spec
> index 01d906a..01b7c29 100644
> --- a/ovirt-node-image.spec
> +++ b/ovirt-node-image.spec
> @@ -85,7 +85,7 @@ mkdir %{buildroot}
>  %{__rm} -rf %{buildroot}
>  
>  %post pxe
> -(cobbler --help) > /dev/null 2>&1 && cobbler sync
> +cobbler sync > /dev/null 2>&1 || :

Ah, I see.  My previous version didn't cause a problem, but just printed out a
bogus %post error message (which is probably why I didn't notice).  This way,
%post exits with a 0 exit code, as you say above.  Good.

ACK

-- 
Chris Lalancette


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]