[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Ovirt-devel] [PATCH node-image] enable SELinux in the node



Jim Meyering <jim meyering net> wrote:

> Here are 5 change sets.
>
> The first enables SELinux in the node.
> However, the resulting .iso image size went up to 72M.
> The following 4 patches pare that back down to 51M, which is 1M below
> the original size of 52M.
>
...
>>From e3d27bd525ecc5f833db60ae4c7088ec3be9ee81 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <meyering redhat com>
> Date: Tue, 16 Sep 2008 21:32:03 +0200
> Subject: [PATCH node-image] common-post.ks: prune blacklisted packages with rpm -e --nodeps
>
> Otherwise, they were not being removed.
> ---
>  common-post.ks |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/common-post.ks b/common-post.ks
> index e234249..d14c790 100644
> --- a/common-post.ks
> +++ b/common-post.ks
> @@ -49,12 +49,14 @@ echo "Removing excess RPMs"
>  # and livecd-tools needs lokkit to disable SELinux.
>  # However, this is just an install-time dependency; we can remove
>  # it afterwards, which we do here
> -rpm -e system-config-firewall-tui system-config-network-tui rhpl \
> +$RPM -e system-config-firewall-tui system-config-network-tui rhpl \
>      rpm-python dbus-python kudzu newt-python newt
> -rpm -e qemu kpartx mkinitrd isomd5sum dmraid python python-libs
>
>  RPM="rpm -v -e --nodeps"
>
> +$RPM -e qemu kpartx mkinitrd isomd5sum dmraid python python-libs

Alan Pevec noticed the above weirdness.
In fact, it's not a use-before-definition of $RPM, but rather an
unnecessary (duplicate) definition.

This incremental change (about to be folded in) removes it.

Thanks, Alan!


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]