[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Ovirt-devel] [PATCH release] Restructured makefile and rpmbuilding to simplify it



On Fri, Sep 19, 2008 at 01:35:53AM -0400, Perry Myers wrote:
> Removed customized rpm macros that should really be set by users
> ~/.rpmmacros directory.  This removed need for custom tar target,
> as we can now use dist and rpmbuild -ta instead.
> 
> Still need to have custom RPM_FLAGS for ovirt specific overrides
> like OVIRT_CACHE_DIR (used by appliance and node-image spec files)
> 
> Removed unused bumprelease, bumpversion and setversion targets
> Removed other unused make variables
> Simplified publish to just rsync all RPMS frpm the rpmdir.
> Added seconds granularity to git tag for bumpgit target.
> 
> Made it so version file is no longer edited by makefile.
> Instead configure.ac file is used to store version.  For
> developers setting OVIRT_DEV env var causes extra_dist to be
> passed to rpmbuild adding the git tag onto the RPM.
> 
> Signed-off-by: Perry Myers <pmyers redhat com>

ACK

> index 0000000..c053339
> --- /dev/null
> +++ b/configure.ac
> @@ -0,0 +1,11 @@
> +AC_INIT([ovirt-release], [0.93], [ovirt-devel redhat com])
> +AM_INIT_AUTOMAKE([-Wall -Werror foreign -Wno-portability])
> +AC_PROG_CC
> +AC_CONFIG_HEADERS([config.h])
> +
> +# If using gcc and default CFLAGS, enable some warnings.
> +test x"$ac_ct_CC:$CFLAGS" = 'xgcc:-g -O2' \
> +  && CFLAGS="$CFLAGS -Wshadow -Wall -Werror"


Technically we should probe the compiler to check supported Cflags.
Not critical for this time around though - we can steal the m4 from
libvirt repo to do the flag probing later on - and we'll get lots of
extra warning flags for free.

> +Version:        @VERSION@
> +Release:        0%{?git_release}%{?dist}%{?extra_release}
> +Source0:        %{name}-%{version}.tar.gz

Can we merg git_release into extra_release too.

Regards,
Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]