[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Ovirt-devel] [PATCH node] Restructured makefile and rpmbuilding to simplify it



Daniel P. Berrange wrote:
+Version:        @VERSION@
+Release:        0%{?git_release}%{?dist}%{?extra_release}

Do you need the %git_release bit to be in front of the %dist tag ? I'd
guess not because %dist is basically a constant for any one developer's
build host. The %git_release & %extra_release are essentially serviing
the same purpose - append a unique extra token - the latter is used by
autobuild. So we could simplify it tiny a little by just merging the
two tags:

    Release:        0%{?dist}%{?extra_release}

and then just set %extra_release to contain the current %git_release data
when calling it in the Makefile.am.

I suggested git_release to be closer to http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages
Release Tag for Pre-Release Packages: 0.%{X}.%{alphatag}

and http://fedoraproject.org/wiki/Packaging/DistTag
append %{?dist} to the end

I couldn't find guideline about extra_release.

But, Fedora guidelines are not set in stone, we already dropped %{X} part and we don't need to support upgrades across distros, so your suggestion would work for all practical purposes.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]