[Ovirt-devel] [PATCH server] Fixed a few bugs in o-identify-node processing.

Mohammed Morsi mmorsi at redhat.com
Wed Apr 1 20:01:25 UTC 2009


>>          # iterate over any nics left and create new records for them.
>> -        nic_info.collect do |nic|
>> -            puts "Creating a new nic..."
>> +        nic_info.each do |nic|
>> +            puts "Creating a new nic: #{nic.interface_name} [#{nic.mac}]"
>>   
>>     
> In this puts statement you are accessing the 'nic' object as if it were
> an instance of the Nic class but really it is just a member of the
> nic_info has retreived from the node. This will either need to be
> changed to nic['INTERFACE_NAME'] and ['MAC'] or moved a few lines below,
> accessing the attributes through the detail object created.
>
>   
ACK pending this small bugfix.

    -Mo




More information about the ovirt-devel mailing list