[Ovirt-devel] [PATCH server] first round of permissions refactoring.

Scott Seago sseago at redhat.com
Tue Apr 14 19:22:57 UTC 2009


Jason Guiditta wrote:
> ACK, one super-minor nit inline.
>
> -j
>
>   
>> +class AddRolesAndPrivileges < ActiveRecord::Migration
>> +  def self.up
>> +#    create_table :permissions do |t|
>> +#      t.string  :user_role
>> +#      t.string  :user
>> +#      t.integer :pool_id
>> +#      t.integer :inherited_from_id
>> +#      t.integer :lock_version, :default => 0
>> +#    end
>>     
>
> Unless there is a reason to keep the above, could you delete it rather
> than commenting out
Agreed. I was only leaving it there while I was writing the initial 
migration and had intended on removing before I sent the patch. I think 
I already pulled this out on my local checkout.

Will push soon.
Scott




More information about the ovirt-devel mailing list