[Ovirt-devel] [PATCH node] Add removal of the boot partition to the uninstall feature.

[Darryl L. Pierce]

On Thu, Feb 26, 2009 at 12:08:50AM +0100, Alan Pevec wrote:
> On Wed, Feb 25, 2009 at 7:38 PM, Darryl L. Pierce <dpierce at redhat.com> wrote:
> > +    log "Labeling boot partition"
> > +    tune2fs -L OVBOOT ${DRIVE}1
> 
> it's already labeled when fs is created:  mke2fs -j "${DRIVE}1" -L "BOOT"
> so old local installations with BOOT won't be uninstalled if we change
> to OVBOOT now.
> Did you want to change to OVBOOT to lower the conflict possibility?
> Default RHEL/Fedora uses lablel "/boot" so BOOT shouldn't have
> conflicts.

It was just an attempt to keep it firmly differentianted. However,
you're right that BOOT is differentiated enough. I'll adjust to use BOOT
instead.

> Also, label BOOT is used at least in mount_boot() so that would need
> to be adjusted.

Okay, sorry I missed that.

> > +       partition=$(findfs LABEL=OVBOOT)
> > +       if [ -n "$partition" ]; then
> > +           log "Unmounting boot partition"
> > +           umount $partition
> > +           log "Removing partitions"
> > +           drive=$(echo $partition | awk '{ match($0, "(.*)[0-9]$", drive); print drive[1] }')
> or just: awk '{ print substr($0,1,length($0)-1); }'

Noted.

-- 
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Virtual Machine Management - http://www.ovirt.org/
Is fearr Gaeilge bhriste ná Béarla cliste.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/ovirt-devel/attachments/20090226/65ccf33f/attachment.sig>