[Ovirt-devel] [PATCH] Add task list to dashboard

[Scott Seago]

Scott Seago wrote:
> David Lutterkort wrote:
>
>>       * Some general comments on how task lists are displayed (nothing
>>         to do with this patch in particular):
I've just submitted a patch dealing with a few of these issues.
>>              1. Could we use an icon to indicate state ? Using a whole
>>                 column is kinda bulky, and not as informative as a nice
>>                 icon
>>   
> The icon would be useful, yes, but we may still want the column so we 
> can sort and filter by it. Anyway perhaps it's a point to work through 
> w/ Jeremy.
We still need to work through w/ jeremy how best to handle this.
>>              2. The column 'Message' is only visible after scrolling,
>>                 even though it's pretty important - that should be moved
>>                 to a more prominent position (like right next to
>>                 'Action')
>>   
> Easy enough to do.
Done.
>>              3. The column 'Args' is almost always empty - why not just
>>                 drop it from the default view, or roll the info from
>>                 that into another column, e.g. Action
>>   
> Hmm. Yeah it's empty for the basic VM actions, but migrate, etc can 
> use it. Joining it w/ action might be just the right thing though. So 
> for "start_vm" we still have just that. But for migrate_vm w/ the arg 
> being the host w/ ID 5 it would say "migrate_vm 5".
I've rolled 'args' into the 'action' column (when it's non-null)
>>              4. It would be nice if you could combine several of the
>>                 Type resp. State filters (like look at all Storage and
>>                 Storage Volume tasks) - and as somebody else mentioned,
>>                 a clearer indication of the currently active filters
>>   
> Yeah redoing the filter setup is another task on the sprint list which 
> will involve reworking filter display and adding date ranges. Perhaps, 
> time permitting, we could look into filtering by groups as well, 
> depending on how much work it is.
I've handled the currently active filter display -- the active ones show 
up in the label for the filter menu. If we want to group states or types 
(rather than just show one at a time) that is fine -- we just need to 
make a decision on how they should be grouped.
>>              5. Conceptually, do users really care about the distinction
>>                 between 'Storage' and 'Storage Volume' tasks ? Why not
>>                 just lump them all into 'Storage tasks' ?
>>
>>   
> Well the task type distinction is more for the benefit of taskomatic 
> than for users -- the task type determines the behavior of the task. 
> Different object pointed to, different ruby class implementation, etc. 
> If there's a need for a more human-friendly categorization of tasks, 
> we could consider adding it, but we shouldn't mix that up w/ 'type' 
> which has model and class implications. In addition, a category-like 
> 'type' field would allow us to distinguish different types of VM tasks.
>
As mentioned in the comments for 4, we can group task types for 
filtering purposes, although we should still display the actual task 
type. All we need to do to get moving on the grouping is to decide what 
to group.

Scott