[Ovirt-devel] [PATCH node] Changed how max swap size is calculated.

Darryl L. Pierce dpierce at redhat.com
Wed Jan 14 22:01:28 UTC 2009


On Wed, Jan 14, 2009 at 10:37:57PM +0100, Alan Pevec wrote:
> > If overt_overcommit is not present, then the default value used is 1.5.
> 
> overt -> ovirt - or should we rename the project to make spell-checkers
> happy? :)

D'oh!  :)

>     # if we didn't find any devices using HAL, so check for virtual devices
> > -    if [ -z $devices ]; then devices=$(ls -l /dev/[shv]d?);  fi
> > +    if [ -z "$devices" ]; then devices=$(ls -l /dev/[shv]d?);  fi
> >
> 
> please push that as a separate commit, otherwise we'll be confused few
> months from now when running git blame

Done.

> > +if [ -z "$OVIRT_OVERCOMMIT" ]; then OVIRT_OVERCOMMIT="1.5"; fi
> >
> 0.5

I removed this. It was some vestigial testing code.

> > SWAP_SIZE=${OVIRT_VOL_SWAP_SIZE:-$MEM_SIZE}
> >
> 
> if  OVIRT_VOL_SWAP_SIZE is defined, it should be used w/o changes, we don't
> try to correct admin input,
> so above line should come last

Done, and the check for a maximum swap size have been removed.

-- 
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Virtual Machine Management - http://www.ovirt.org/
"What do you care what other people think, Mr. Feynman?"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/ovirt-devel/attachments/20090114/3c34b876/attachment.sig>


More information about the ovirt-devel mailing list