[Ovirt-devel] [PATCH node] Fixed check for whether the network restarted.

[Alan Pevec]

On Mon, Jan 19, 2009 at 11:32 PM, Darryl L. Pierce <dpierce at redhat.com>wrote:

> The last network interface touched by the script is checked to see if it
> has active ARP entries. If not then the restart is considered a failure
> even through the service itself restarted.
>

Background of this patch is that /etc/init.d/network script returns 0 even
after printing FAILED for some interfaces.
Unfortunately checking for ARP cache entries is fragile: works after
successful DHCP session, but fails if we configured static IP

+    if [[ $net_check =~ "no match found" ]]; then
>         log "Error configuring network, see $OVIRT_LOGFILE"
>

should also return non-0 error code otherwise confusing  success message is
printed right after error:

http://apevec.fedorapeople.org/o-c-netcfg-fail-no-dhcp.png
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/ovirt-devel/attachments/20090120/8353e909/attachment.htm>