[Ovirt-devel] [PATCH server] UI for accumulated uptime for VMs. (revised3)

Jason Guiditta jguiditt at redhat.com
Mon Jul 6 19:18:45 UTC 2009


On Mon, 2009-07-06 at 18:31 +0000, Scott Seago wrote:
> This revised version of the patch incorporates jguiditta's sorting fix as well as some other changes required to make this work fully on the cloud UI side.
> ---
>  src/app/controllers/pool_controller.rb        |    2 +-
>  src/app/controllers/resources_controller.rb   |    4 +++-
>  src/app/controllers/smart_pools_controller.rb |    7 +++----
>  src/app/helpers/application_helper.rb         |   14 ++++++++++++++
>  src/app/models/vm.rb                          |   11 ++++++++++-
>  src/app/views/cloud/instance/_list.rhtml      |    4 ++++
>  src/app/views/vm/_grid.rhtml                  |    1 +
>  src/app/views/vm/show.rhtml                   |    4 +++-
>  src/test/unit/vm_test.rb                      |    6 ++++++
>  9 files changed, 45 insertions(+), 8 deletions(-)

Mostly ACK.  I have one bit of weirdness on mine that I would like to
see someone verify (or say it is just me).  In the vm grids for resource
pools and smart pools, the 'Total Run Time' column is blank on mine.  I
get numbers in cloud/instance though.  All other errors/issues discussed
in irc seem to be corrected now.

-j




More information about the ovirt-devel mailing list