[Ovirt-devel] Re: [PATCH node] Follow on patch for bz#507393.

[Alan Pevec]

Darryl L. Pierce wrote:
> This patch adds a warning to the NTP changes.

this looks good, just few things need to be amended:

>  function configure_dns

> +                echo "Enter up to two DNS servers separated by commas:"

Isn't that changed to input one per line as for NTP?

> +                read -ep "Is this correct (Y/N/A)? "

should use ask_yes_or_no

> @@ -251,13 +263,23 @@ function configure_ntp

> +        if has_configured_interface true; then

> +            while true; do
> +                read -ep "By continuing, you will remove any existing NTP settings. Continue (y/n)? "
drop this additional warning, top-level "Configuring the network will destroy any existing networking" is enough