[Ovirt-devel] Re: [PATCH node] Provides a means to toggle SSH password auth from the firstboot menu. rhbz#509842

[Darryl L. Pierce]

On Fri, Jul 10, 2009 at 08:32:02PM +0200, Alan Pevec wrote:
> Darryl L. Pierce wrote:
>> The password option now goes to a submenu. This submenu lets the user
>> chose to either set the administrator password or else toggle SSH
>> password authentication on or off.
>
> as discussed off-line, this toggle prompt is confusing, I'd like to ACK and push with the attached amendment and small fix:
>
>> +    augtool get /files/etc/ssh/sshd_config/PasswordAuthentication|grep -q yes$
> need /usr/bin/augtool otherwise override from ovirt-functions is used, which doesn't accept commands as parameter

> diff --git a/scripts/ovirt-config-password b/scripts/ovirt-config-password
> index 78ec5ba..a87931b 100755
> --- a/scripts/ovirt-config-password
> +++ b/scripts/ovirt-config-password
> @@ -65,11 +65,9 @@ EOF
>  }
>  
>  toggle_ssh () {
> -    local prompt=$1
> +    printf "\nSSH password authentication\n\n"
>  
> -    printf "\nToggle SSH\n\n"
> -
> -    if ask_yes_or_no "${prompt} (y/n)?"; then
> +    if ask_yes_or_no "Enable SSH password authentication (y/n)?"; then
>          toggle_ssh_access true
>      else
>          toggle_ssh_access false
> @@ -82,7 +80,7 @@ QUIT="Quit and Return To Menu"
>  
>  while true; do
>      state="disabled"
> -    augtool get /files/etc/ssh/sshd_config/PasswordAuthentication|grep -q yes$
> +    /usr/bin/augtool get /files/etc/ssh/sshd_config/PasswordAuthentication|grep -q yes$
>      if [ $? == 0 ]; then
>          state="enabled"
>       fi
> @@ -93,7 +91,7 @@ while true; do
>      do
>          case $option in
>              $PASSWORD) set_password; break;;
> -            $SSH) toggle_ssh "$prompt"; break;;
> +            $SSH) toggle_ssh; break;;
>              $QUIT) exit;;
>          esac
>      done

ACK. That wording is very clear.

-- 
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Virtual Machine Management - http://www.ovirt.org/
Is fearr Gaeilge bhriste ná Béarla cliste.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/ovirt-devel/attachments/20090710/e4265388/attachment.sig>