[Ovirt-devel] [PATCH node] updated unpersist prompts bz512539

[Darryl L. Pierce]

On Tue, Jul 21, 2009 at 03:12:26PM -0400, Joey Boggs wrote:

ACK with one comment.

> ---
>  scripts/ovirt-functions |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/scripts/ovirt-functions b/scripts/ovirt-functions
> index 404c366..7657bae 100644
> --- a/scripts/ovirt-functions
> +++ b/scripts/ovirt-functions
> @@ -508,8 +508,16 @@ remove_config() {
>                      if [ -f /config$f ]; then
>                          # refresh the file in rootfs if it was mounted over
>                          cp -a /config$f $f
> +                        if [ $? -ne 0 ]; then
> +                            printf " Failed to unpersist %s\n" $f
> +                            rc=1

I don't see where rc is being used. Can you remove it before pushing?

> +                        else
> +                            printf " %s successully unpersisted\n" $f
> +                        fi
>                      fi
>                  fi
> +            else
> +                printf " %s is not in persistent storage" $f
>              fi
>              # clean up the persistent store
>              rm -f /config$f
> -- 
> 1.6.2.5
> 
> _______________________________________________
> Ovirt-devel mailing list
> Ovirt-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/ovirt-devel

-- 
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Virtual Machine Management - http://www.ovirt.org/
Is fearr Gaeilge bhriste ná Béarla cliste.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/ovirt-devel/attachments/20090722/c5c3147a/attachment.sig>